Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: --sapFontHeaderFamily in High Contrast White theme seems to be incorrect #19

Closed
VictorHumanist opened this issue Jun 7, 2024 · 3 comments

Comments

@VictorHumanist
Copy link

In css_variables.css from sap_horizon_hcw, the --sapFontHeaderFamily variable is defined as follows:
--sapFontHeaderFamily: "72", "72full", Arial, Helvetica, sans-serif;

While in sap_horizon_hcb, as well as sap_horizon and sap_horizon_dark, it is defined like this:
--sapFontHeaderFamily: "72-Bold", "72-Boldfull", "72", "72full", Arial, Helvetica, sans-serif;
Which looks like the correct definition.

Version: 11.15.0

@dominikschreiber
Copy link
Contributor

Hi @VictorHumanist, you have the eyes of an eagle!

I had a quick chat with colleagues from SAP Design. Having @sapFontHeaderFamily mapped to @sapFontFamily in Horizon HCW and to @sapFontBoldFamily everywhere else is intentional. Hence, I'll close this issue.

Nevertheless, I'd be interested if this outlier causes issues for you. Can you share your use-case?

@dominikschreiber dominikschreiber closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2024
@VictorHumanist
Copy link
Author

I just noticed that the form headers are not bold in HCW, while bold in others, including HCB:

image_2024-06-10_141300698

image_2024-06-10_142000289

Quick investigation showed the reason, and I naturally thought it was a mistake.
Header spec was taken from https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2698913674

Guess I should just add font-weight: bold.

@dominikschreiber
Copy link
Contributor

Thank you for your quick feedback! After more consideration, SAP Design now has the impression that sapFontHeaderFamily should not be bold in Horizon HCB as well. They updated the Theming – Typography (Horizon) specification to reflect that. I'll also show them the link you provided and ask to keep both in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants