This repository has been archived by the owner on Jan 28, 2020. It is now read-only.
Correctly escape the ^ for Windows #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
RomainLanz
force-pushed
the
windows-arguments
branch
from
01c64aa
to
63130ab
Compare
|
Hey @sapegin! 馃憢 It should be good. I have also extracted the |
RomainLanz
force-pushed
the
windows-arguments
branch
from
036aad5
to
dc7d56f
Compare
targos
reviewed
Dec 7, 2019
sapegin
reviewed
Dec 8, 2019
|
Should be good by now! |
RomainLanz
force-pushed
the
windows-arguments
branch
from
e6c4254
to
92ca501
Compare
RomainLanz
force-pushed
the
windows-arguments
branch
from
92ca501
to
80cd3dd
Compare
sapegin
suggested changes
Dec 9, 2019
|
馃帀 This PR is included in version 4.0.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 馃憢
This PR ensure that the
execCommandcorrectly escape the^for Windows.On Windows, the
npm.cmdoryarn.cmdfile will be called which is a Batch Script. In a Batch Script, the character^is the escaping character, which means it wasn't passed to the realnpm/yarn.Examples:
> npm.cmd install --save @eslint@^6.0.0This command was in fact installing
eslint@6.0.0.Credits to @targos for the help.