si_code issue in metrics tidyfier

[vflo]

A potential issue in metrics_tidyfier due to lack of match between si_code and pl_code. The function returns si_code = NA.

raw_index <- stringr::str_detect(names(sapf_data[["sapf"]])[2], raw_codes)

This issue was found in "COL_MAC_SAF_RAD" because the codes of plants are incomplete (e.g. "COL_MAC_SAF_Tca_Js_1").

The problem is not easily solved directly from this function. A possible solution would be to make sfn_metrics also return the site metadata (or at least si_code) in another element of the output list, and then in metrics_tidyfier extract si_code directly from the metrics_res input variable.

However, this is a database quality control problem rather than an unforeseen use case problem. I would not make any changes for the moment.