You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently compareHashes function calculates the result of comparison using default division operator and php's round() function, which may produce inconsistent and inprece results. Also, the default precision for all methods is set to 1, which may also produce confusing results.
We can slightly improve this aspect by utilizing php's bcmath functions or Brick's Math php package: https://github.com/brick/math. Also it would be beneficial to change default precision from 1 to a higher number
The text was updated successfully, but these errors were encountered:
Currently
compareHashes
function calculates the result of comparison using default division operator and php'sround()
function, which may produce inconsistent and inprece results. Also, the default precision for all methods is set to 1, which may also produce confusing results.We can slightly improve this aspect by utilizing php's bcmath functions or Brick's Math php package: https://github.com/brick/math. Also it would be beneficial to change default precision from 1 to a higher number
The text was updated successfully, but these errors were encountered: