Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comparison results precision #4

Open
vadymtsots opened this issue Mar 15, 2024 · 0 comments
Open

Improve comparison results precision #4

vadymtsots opened this issue Mar 15, 2024 · 0 comments

Comments

@vadymtsots
Copy link
Collaborator

Currently compareHashes function calculates the result of comparison using default division operator and php's round() function, which may produce inconsistent and inprece results. Also, the default precision for all methods is set to 1, which may also produce confusing results.

We can slightly improve this aspect by utilizing php's bcmath functions or Brick's Math php package: https://github.com/brick/math. Also it would be beneficial to change default precision from 1 to a higher number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant