Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging dependencies #6

Open
wbobeirne opened this issue Mar 17, 2022 · 1 comment
Open

Remove logging dependencies #6

wbobeirne opened this issue Mar 17, 2022 · 1 comment

Comments

@wbobeirne
Copy link
Contributor

We can remove debugnyan and @uphold/request-logger in favor of just using a small custom console.log-based logger, and letting implementors of the library use the logger param to pass a logger of their choosing.

The custom logging implementation should be API compliant with bunyon to keep backwards compatbility, and make it easy to plug other logger solutions into.

@JeremyRubin
Copy link
Contributor

feel free to add a dep to https://www.npmjs.com/package/@types/bunyan to give this typescript types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants