Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate skip from limit #170

Closed
groenroos opened this issue Apr 4, 2021 · 0 comments · Fixed by #173
Closed

Separate skip from limit #170

groenroos opened this issue Apr 4, 2021 · 0 comments · Fixed by #173
Assignees
@groenroos
Labels
enhancement Improvements to existing features and functionality
Milestone
M2 - Release 2.0

Comments

@groenroos
Copy link
Member

Currently, the limit query string var allows defining two CSV values, with one used as a skip value for pagination;

GET /data/posts?limit=20,10

This doesn't feel very readable; i.e. it's not obvious which one is the limit and which one is skip. Refactor these into separate values:

GET /data/posts?limit=10&skip=20
@groenroos groenroos added the enhancement Improvements to existing features and functionality label Apr 4, 2021
@groenroos groenroos added this to the M2 - Release 2.0 milestone Apr 4, 2021
@groenroos groenroos self-assigned this Apr 4, 2021
@groenroos groenroos mentioned this issue Apr 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@groenroos groenroos

Labels
enhancement Improvements to existing features and functionality
Milestone
M2 - Release 2.0
Development

Successfully merging a pull request may close this issue.

Separate skip from limit saplingjs/sapling
1 participant
@groenroos