Performance improvement for GET_ROW method

[bilencekic]

Issue #527 has been fixed after updating ZCL_EXCEL_ROWS class by removing object iterator and introducing hash table. ZCL_EXCEL_WORKSHEET->GET_ROW method has been updated accordingly based on new structure to read directly from hash table.
Before :

And after:

[ivanfemia]

Thanks for your contribution
Do we still need the method GET_ITERATOR?

I would also suggest to have the DT_ROWS as protected, so no other class can change the content of the internal table.

[bilencekic]

@ivanfemia it is easier to add READ ONLY statement, in this case it will be public which is easy to access and can only be changed inside the class;

    DATA:
          DT_ROWS TYPE HASHED TABLE OF T_ROWS WITH UNIQUE KEY ROW_INDEX READ-ONLY.

Get iterator we don't need i think it only exists in worksheet class, it is safe to delete.
I can do above changes as well if you want.

[ivanfemia]

That's great!
thank you!

[EMSINSANE]

Hi. Just ( 27.03.18 ) installed the Project.
Class ZCL_EXCEL_WORKSHEET contains Syntax-Errors because the deleted Method ZCL_EXCEL_ROWS->GET_ITERATOR() is used in ZCL_EXCEL_WORKSHEET->GET_ROWS_ITERATOR().

So Long

Insane

[ivanfemia]

@EMSINSANE can you try to remove ZCL_EXCEL_WORKSHEET->GET_ROWS_ITERATOR() it should not be used anywhere... I have no access to a NetWeaver server at the moment.
You can either commit the change to the repository or tell us that this fixed the issue.

Thank you
Ivan

[larshp]

The syntax error:

GET_ROWS_ITERATOR() is used in the following places,