Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement for GET_ROW/GET_COLUMN #544

Merged
merged 2 commits into from Jul 17, 2018

Conversation

Pacojka
Copy link

@Pacojka Pacojka commented Jul 14, 2018

Hallo Ivan,

i implemented the changes as described in issue #528 for rows and columns objects.

I kept the object_collection and the get_iterator method because lack of time and the visibility (public) of the get_iterator method.

In the worksheet class, I changed get_row and get_column.

@Pacojka
Copy link
Author

Pacojka commented Jul 16, 2018

I tested the change using ZDEMO_EXCEL15. Everything looks fine.
The performance improvement is as expected.

@ivanfemia
Copy link
Collaborator

Thanks.
I think that we should improve this removing completely the iterator and the few methods no longer needed... But first of all we need to mark those as obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants