Support for comments (Issue #180) #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As contributed by guillaumegarcia13
… cell_comments
… into cell_comments
As contributed by guillaumegarcia13
|
looks okay, however, I did not test it I think we should consider adding some development guidelines, eg use of pretty printer + do we prefix or not prefix, I have suggestions for both, however just find it important to align across the code in the project |
|
lets just merge it? |
|
Merged |
|
I noticed that comments are not displaying in the second sheet if no comments set in the first sheet. |
|
@jonothomask please open an issue for the found issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As contributed by @guillaumegarcia13