Issue #588: Unable to activate zcl_excel_writer_xlsm #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create_xl_sheet_rels has a required parameter iv_comment_index. This was not populated in this version. When transporting the transport goes in error because he can't activate this class. adding lv_comment_index like it is in zcl_excel_writer_2007 corrects this problem.
ZCL_EXCEL_WRITER_XLSM add required parameter
|
Excellent. Can you just do a pretty print keywords uppercase, variables lowercase and a alignment of the new type definition? |
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the required parameter iv_comment_index in method create_xl_sheet_rels of issue #188. You are not able to activate class zcl_excel_writer_xlsm. View Issue #588. This corrects that problem.