Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefinition Header Footer Image #601

Merged
merged 2 commits into from Feb 25, 2019
Merged

Redefinition Header Footer Image #601

merged 2 commits into from Feb 25, 2019

Conversation

mfallen
Copy link
Contributor

@mfallen mfallen commented Feb 21, 2019

Get errors when using header/footer in more than one sheet

Get errors when using header/footer in more than one sheet
@gregorwolf
Copy link
Collaborator

Can you try to have less differences in zcl_excel_worksheet.clas.abap? There where a lot of spaces removed or added.

@mfallen
Copy link
Contributor Author

mfallen commented Feb 25, 2019

Hi @gregorwolf , looks like in the original coding there are "too much" spaces?

@gregorwolf
Copy link
Collaborator

Perhaps we could be really radical and do a pretty print with keywords uppercase, variables lowercase in the code based class editor.

@larshp
Copy link
Member

larshp commented Feb 25, 2019

pretty print keywords upper in class based editor is also what we do in abapGit, plus it can be automatically enforced via abaplint

@mfallen
Copy link
Contributor Author

mfallen commented Feb 25, 2019

@gregorwolf @larshp Done, "pretty printed" the class

@gregorwolf gregorwolf merged commit e3784a2 into abap2xlsx:master Feb 25, 2019
@gregorwolf
Copy link
Collaborator

Thanks.

@mfallen mfallen deleted the headerfooter branch February 26, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants