Fix Issue #610 (Error if last column of last row is empty) #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into the troubles as described in issue #610 an pasted in solution as suggested there.
The value of variable "lv_rc" which is checked here comes from a previous READ TABLE statement in method get_cell(). Apparently ABAP sets the return value to "8", when the last line of a internal
table has been reached with TABLE KEY search, even though from my point of view the ABAP documentation (see attachment) is not 100% precise here. Nevertheless i can't see any reason why "8" (reached last row) should be treated different from "4" (did not last row) in this context.
In fact from my point of view the whole exception handling in method get_table after me->get_cell()... (lines 96 et seq.) is (or has become) pointless and could be removed. But for now I wanted to keep the change as minimal as possible.