Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATC check cleared #657

Merged
merged 2 commits into from Apr 17, 2020
Merged

ATC check cleared #657

merged 2 commits into from Apr 17, 2020

Conversation

d-schaaf
Copy link
Contributor

We found ATC check "Empty SELECT... ENDSELECT loop" when selecting the date format from USR01.

  • removed SELECT * from USR01
  • removed empty SELECT...ENDSELECT on URS01 and changed into SELECT SINGLE

removed SELECT * from USR01
removed empty SELECT...ENDSELECT on URS01
ZIF_EXCEL_READER~CAN_READ_FILE was implemented but this method is not defined anymore in the Interface.
ATC check failed with incorrect syntax.
Solution: Method implementation deleted.
@d-schaaf
Copy link
Contributor Author

Fixed another ATC issue in ZCL_EXCEL_READER_2007: ZIF_EXCEL_READER~CAN_READ_FILE was implemented but method no more defined in the interface. Method implementation has been deleted

@gregorwolf
Copy link
Collaborator

LGTM

@gregorwolf gregorwolf merged commit 718b150 into abap2xlsx:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants