Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change package assignment of demo reports #699

Merged
merged 2 commits into from Oct 1, 2020
Merged

Change package assignment of demo reports #699

merged 2 commits into from Oct 1, 2020

Conversation

bigld
Copy link
Collaborator

@bigld bigld commented Oct 1, 2020

closes #695

only move demo reports to subpackage so one can pull "core" only with Ignore Subpackages

@gregorwolf gregorwolf marked this pull request as ready for review October 1, 2020 19:15
gregorwolf
gregorwolf approved these changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@gregorwolf gregorwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregorwolf gregorwolf merged commit 5a9408b into abap2xlsx:master Oct 1, 2020
@WouterPeeters
Copy link

@gregorwolf @bigld can we also change the package for the Webdynpro demo's? E.g. ZDEMO_EXCEL_WDA01

@larshp
Copy link
Member

larshp commented Oct 7, 2020

@WouterPeeters yea, pull requests welcome

@bigld
Copy link
Collaborator Author

bigld commented Oct 7, 2020

here we go: #702 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregorwolf gregorwolf gregorwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package structure
4 participants
@bigld @WouterPeeters @larshp @gregorwolf