Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print #781

Merged
merged 2 commits into from Jul 27, 2021
Merged

Pretty print #781

merged 2 commits into from Jul 27, 2021

Conversation

pokrakam
Copy link
Contributor

Pretty print everything in keyword upper / identifier lower in one dedicated commit in order to avoid large diff problem
Closes #780 if agreement to use this as a project standard.

Even if a different standard will be used in future, at least everything is in one format now.

@larshp
Copy link
Member

larshp commented Jul 27, 2021

@AndreaBorgia-Abo what would you like to do? if you review this one, it can be merged, but will probably cause conflicts in all open PRs

@AndreaBorgia-Abo
Copy link
Member

@larshp I guess it can't be helped and I'm fine with a little extra work as long as this is once and for all.
Perhaps we should first write the preferred settings in the coding guidelines (hello @sandraros ) and commit that PR, so that when we pull this one in we are able to reference the guidelines in all conflicting PRs and ask contributors for a little extra editing. All onboard with this?

@larshp
Copy link
Member

larshp commented Jul 27, 2021

and much of the pretty-printing can be enforced by the linter

@pokrakam
Copy link
Contributor Author

Agree with @AndreaBorgia-Abo
On a couple of random checks several open PRs already have conflicts.

@sandraros
Copy link
Collaborator

Agreed with all @AndreaBorgia-Abo @pokrakam @larshp : to add it to the coding guidelines first ; then update the linter settings ; and ask people to resolve PR conflicts or do it ourselves (like mines or #669 that I am currently reviewing)

@AndreaBorgia-Abo
Copy link
Member

Very well, I'll have a look this evening

Copy link
Member

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some funny new elements in demos/zdemo_excel_wda01.wdyn.xml it looks just as described: differences are either formatting-related or keyword lowercase to uppercase conversion and viceversa for identifiers.
Pulled the tree in my 7.52SP04 demo, all objects active, good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonize pretty print settings
4 participants