Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move zexcel_s_org_rel to demos #810

Merged
merged 4 commits into from Sep 26, 2021
Merged

move zexcel_s_org_rel to demos #810

merged 4 commits into from Sep 26, 2021

Conversation

larshp
Copy link
Member

@larshp larshp commented Sep 26, 2021

moves the structure zexcel_s_org_rel to demos, its only part of demos not core functionality

@sandraros
Copy link
Collaborator

LGTM

@sandraros sandraros merged commit 88d75bf into master Sep 26, 2021
@sandraros sandraros deleted the hvam/move2609 branch September 26, 2021 08:07
@sandraros
Copy link
Collaborator

@larshp I had difficulties with abapGit to pull the master because of zexcel_s_org_rel which was "simply" moved to the demos package.
Initial situation. In abapGit, I removed the repository (Advanced>Remove) to start from scratch, restarted abapGit:
image
I did Advanced>Selective Pull:
image
image
image
image

So, I deleted the program ZDEMO_EXCEL11 (which uses ZEXCEL_S_ORG_REL) and then ZEXCEL_S_ORG_REL, and did a pull. Perfectly working.

My question: is there a related issue in abapGit? (maybe abapGit#842/abapGit#2706)
Thanks.

@larshp
Copy link
Member Author

larshp commented Sep 26, 2021

delete ZEXCEL_S_ORG_REL and pull again

yea, there might be some issues moving stuff between packages and/or uninstalling

@sandraros
Copy link
Collaborator

@larshp Do you think it's worth adding this example to an existing abapGit issue or to add one?

@larshp
Copy link
Member Author

larshp commented Sep 26, 2021

feel free to open an issue 😄

@sandraros
Copy link
Collaborator

For information, issue abapGit#4974 created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants