Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #547 autofilter messed up if several sheets #821

Merged
merged 3 commits into from Oct 4, 2021
Merged

Fix #547 autofilter messed up if several sheets #821

merged 3 commits into from Oct 4, 2021

Conversation

sandraros
Copy link
Collaborator

Fix #547

@sandraros sandraros mentioned this pull request Oct 3, 2021
Closed
AndreaBorgia-Abo
AndreaBorgia-Abo approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Either here or in the next PR, ZEXCEL_DEMO37 is missing some selection texts since the dawn of time, apparently: could you add them?

@larshp larshp merged commit 1076b86 into master Oct 4, 2021
@larshp larshp deleted the issue-547-autofilter branch October 4, 2021 14:50
@sandraros
Copy link
Collaborator Author

@AndreaBorgia-Abo and @larshp Thanks so much! I have created #826 for fixing ZDEMO_EXCEL37 another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaBorgia-Abo AndreaBorgia-Abo AndreaBorgia-Abo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autofilter does not working correctly when using a template
3 participants
@sandraros @AndreaBorgia-Abo @larshp