Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear exporting parameter GET_CELL #789 #840

Merged
merged 4 commits into from Oct 9, 2021

Conversation

bigld
Copy link
Collaborator

@bigld bigld commented Oct 7, 2021

closes #789

@bigld bigld closed this Oct 7, 2021
@bigld bigld reopened this Oct 7, 2021
@sandraros sandraros self-assigned this Oct 8, 2021
Copy link
Collaborator

@sandraros sandraros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Could you merge the latest master changes into your branch please? Thanks!

@larshp
Copy link
Member

larshp commented Oct 9, 2021

make sure to set "allow edits from maintainers", https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

its usually enabled by default

@sandraros sandraros merged commit 2cda265 into abap2xlsx:master Oct 9, 2021
@sandraros
Copy link
Collaborator

Thanks! 👍

@bigld bigld deleted the issue_789 branch October 9, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET_CELL may return a style in EP_STYLE although cell has no style
3 participants