Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SET_CELL_FORMULA: set formula even if cell was uninitialized #868

Merged
merged 4 commits into from Nov 4, 2021

Conversation

sandraros
Copy link
Collaborator

Fix #866

Fix #866
@larshp
Copy link
Member

larshp commented Nov 4, 2021

The PR title "Fix #866" is the text shown in the PR overview, and typically also what is merged to main if the commits are squashed

suggest having the PR title something like "SET_CELL_FORMULA: fix uninitialized cells"

The issue and PR is linked only by the description of the PR or the comments

@sandraros
Copy link
Collaborator Author

@larshp Thanks for telling me. You're right, I will do the way you suggest.

@sandraros sandraros changed the title Fix #866 SET_CELL_FORMULA: doesn't set it if cell was uninitialized Nov 4, 2021
@sandraros sandraros changed the title SET_CELL_FORMULA: doesn't set it if cell was uninitialized SET_CELL_FORMULA: doesn't set if cell was uninitialized Nov 4, 2021
@sandraros sandraros changed the title SET_CELL_FORMULA: doesn't set if cell was uninitialized SET_CELL_FORMULA: fix to set formula if cell was uninitialized Nov 4, 2021
@sandraros sandraros changed the title SET_CELL_FORMULA: fix to set formula if cell was uninitialized SET_CELL_FORMULA: set formula even if cell was uninitialized Nov 4, 2021
Copy link
Member

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/zcl_excel_worksheet.clas.abap Outdated Show resolved Hide resolved
Co-authored-by: Abo <andrea@borgia.bo.it>
@AndreaBorgia-Abo AndreaBorgia-Abo merged commit 9b6bf15 into master Nov 4, 2021
@AndreaBorgia-Abo AndreaBorgia-Abo deleted the sandraros/set_cell_formula branch November 4, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SET_CELL_FORMULA doesn't work for cells not previously initialized
3 participants