fix syntax error #873
Merged
fix syntax error #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My bad, hopefully you saw that (due to #852). I will review this piece of code because this line of code doesn't seem to have any effect, but I must first understand what the "huge" writer exactly does compared to the classic writer (#875). I'll also do a syntax check before staging, from within abapGit > Advanced > Syntax check (fixing the warnings like #854 will help to easily see the syntax check errors ; also proposing to fix other warnings #874). |
|
this kind of error will be reported as https://github.com/sapmentors/abap2xlsx/runs/4114498317, due to the config change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure where, but some of the recent PRs, introduced a syntax error, this PR fixes the syntax error
Plus enables syntax checking in the abaplint configuration, to avoid this from happening again