Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skeleton around fx rates overrides (dormant; not a priority yet) #284 #388

Merged
merged 8 commits into from Nov 5, 2019

Conversation

theotherian
Copy link
Collaborator

Signed-off-by: Ian Simpson ian.g.simpson@gmail.com

Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #388 into master will increase coverage by 1.7%.
The diff coverage is 63.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #388     +/-   ##
===========================================
+ Coverage     45.98%   47.68%   +1.7%     
- Complexity      572      630     +58     
===========================================
  Files           211      230     +19     
  Lines          3782     4322    +540     
  Branches        179      184      +5     
===========================================
+ Hits           1739     2061    +322     
- Misses         1980     2193    +213     
- Partials         63       68      +5
Impacted Files Coverage Δ Complexity Δ
...ver/spring/settings/web/SecurityConfiguration.java 96.42% <ø> (ø) 7 <0> (ø) ⬇️
...connector/caching/FxRateOverridesLoadingCache.java 0% <0%> (ø) 0 <0> (?)
...g/interledger/connector/DefaultILPv4Connector.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...nnector/fxrates/DefaultFxRateOverridesManager.java 0% <0%> (ø) 0 <0> (?)
...ce/repositories/FxRateOverridesRepositoryImpl.java 100% <100%> (ø) 6 <6> (?)
...ver/spring/settings/web/SpringConnectorWebMvc.java 100% <100%> (ø) 7 <0> (ø) ⬇️
.../server/spring/settings/SpringConnectorConfig.java 87.3% <100%> (+0.2%) 28 <1> (+1) ⬆️
...nce/converters/FxRateOverridesEntityConverter.java 100% <100%> (ø) 4 <4> (?)
...connector/persistence/config/ConvertersConfig.java 100% <100%> (ø) 6 <1> (+1) ⬆️
...tor/persistence/entities/FxRateOverrideEntity.java 56.25% <56.25%> (ø) 9 <9> (?)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686b231...acbe1fb. Read the comment docs.

Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
@sappenin sappenin added this to the 11/08 Sprint milestone Nov 5, 2019
@sappenin sappenin added this to In progress in v0.1.0 Release via automation Nov 5, 2019
Copy link
Collaborator

@sappenin sappenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, but overall LGTM.

@sappenin sappenin self-requested a review November 5, 2019 17:39
Copy link
Collaborator

@sappenin sappenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@theotherian theotherian merged commit 10f59a8 into master Nov 5, 2019
v0.1.0 Release automation moved this from In progress to Done Nov 5, 2019
@theotherian theotherian deleted the is/fx-admin-api branch November 5, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants