New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skeleton around fx rates overrides (dormant; not a priority yet) #284 #388
Conversation
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
bc47507
to
8f06a0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
===========================================
+ Coverage 45.98% 47.68% +1.7%
- Complexity 572 630 +58
===========================================
Files 211 230 +19
Lines 3782 4322 +540
Branches 179 184 +5
===========================================
+ Hits 1739 2061 +322
- Misses 1980 2193 +213
- Partials 63 68 +5
Continue to review full report at Codecov.
|
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, but overall LGTM.
connector-fxrates/src/main/java/org/interledger/connector/fxrates/FxRateOverride.java
Show resolved
Hide resolved
...tence/src/main/java/org/interledger/connector/persistence/entities/FxRateOverrideEntity.java
Show resolved
Hide resolved
...java/org/interledger/connector/persistence/repositories/FxRateOverridesRepositoryCustom.java
Show resolved
Hide resolved
...t/java/org/interledger/connector/persistence/repositories/FxRateOverridesRepositoryTest.java
Show resolved
Hide resolved
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Ian Simpson ian.g.simpson@gmail.com