Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for different android versions in one branch #1

Closed
n-elloco opened this issue Aug 27, 2015 · 2 comments
Closed

Changes for different android versions in one branch #1

n-elloco opened this issue Aug 27, 2015 · 2 comments

Comments

@n-elloco
Copy link

It is proposed to combine the printing methods for different versions of Android in the master branch, because the application can be are designed for different versions of Android. For example, in my application using Ionic Framework and should be supported by devices with Android 4.3+. The file package.json is not possible to specify the install plugin from two branches.

@sarahgoldman
Copy link
Owner

I agree that this should eventually exist in one branch, I just haven't had the time to integrate the Cloud Print method back into master as a fallback. Feel free to make the changes and submit a pull request or I will try to get to this in the near future.

@sarahgoldman
Copy link
Owner

I have just combined the two android printing methods into the master branch. Will use native printing when available, and will fallback to google cloud print for 4.3 and less.

The latest version with this change has been published to npm. Let me know if you have any trouble implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants