Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp the single product screen #22

Open
Saransh-cpp opened this issue Dec 3, 2021 · 20 comments · May be fixed by #105
Open

Revamp the single product screen #22

Saransh-cpp opened this issue Dec 3, 2021 · 20 comments · May be fixed by #105
Assignees
Labels
CodePeak moderate Moderate level issue refactor Refactor the code! SWoC ui/ux Editing the UI/UX

Comments

@Saransh-cpp
Copy link
Owner

Description

The screen where a single product is displayed (a book) looks ugly, I'll see if I can update the data, but update the UI and make it consistent throughout the screen. You might need to deep dive into the code and make sure that nothing breaks, hence, putting this as a moderate issue.

Relevant file

Screenshot

@Saransh-cpp Saransh-cpp added moderate Moderate level issue ui/ux Editing the UI/UX refactor Refactor the code! CodePeak SWoC labels Dec 3, 2021
@ManavSarkar
Copy link

Hi, Can I work on this?
I am Manav Sarkar

@ManavSarkar
Copy link

I have some better designs in my mind for this page

@Saransh-cpp
Copy link
Owner Author

Yes, go ahead!

@Saransh-cpp
Copy link
Owner Author

@ManavSarkar, any updates?

@Pranav108
Copy link
Contributor

Can I take it?

@ManavSarkar
Copy link

Can I take it?

I am already working on it

@ManavSarkar
Copy link

@ManavSarkar, any updates?

Yes sir, almost done and within tomorrow I will submit.
The reason for my late contribution is my final sem exams. But I will do submit by tomorrow.
Thank you

@ManavSarkar
Copy link

ManavSarkar commented Dec 15, 2021

@Saransh-cpp please can you guide where to publish the branch, in upstream or in origin
Getting error
image

@Saransh-cpp
Copy link
Owner Author

Did you clone my repository or the forked repository?

@ManavSarkar
Copy link

Did you clone my repository or the forked repository?

No I just cloned the repository.i was working on the issue 22 branch

@ManavSarkar
Copy link

Did you clone my repository or the forked repository?

No I just cloned the repository.i was working on the issue 22 branch

Have I made any mistake?
Please guide as this is my first time open source contribution.

@arnav1776
Copy link
Collaborator

@ManavSarkar First you have to Fork this Repo using the Fork button which is on the top-right side, then clone the forked repo onto your system, make the desired changes, then create a new branch for your changes, push that branch onto your repo and then open a Pull Request in the main Repository.

@Saransh-cpp
Copy link
Owner Author

Saransh-cpp commented Dec 15, 2021

@ManavSarkar, a workaround for your situation now -

git remote set-url origin your-forked-repo-url
git remote add upstream my-repo-url

Then you can push to origin

@ManavSarkar
Copy link

Can I start from beginning by forking the repository and then paste the product page code. But it will have only single commit. Will that be fine?

@ManavSarkar
Copy link

@Saransh-cpp

@Saransh-cpp
Copy link
Owner Author

Can I start from beginning by forking the repository and then paste the product page code. But it will have only single commit. Will that be fine?

Yes, no issues!

@ManavSarkar
Copy link

@Saransh-cpp Please confirm whether the UI is looking good or not.
71

@Saransh-cpp
Copy link
Owner Author

@all-contributors please add @arnav1776 for mentoring

@allcontributors
Copy link
Contributor

@Saransh-cpp

I've put up a pull request to add @arnav1776! 🎉

@Saransh-cpp
Copy link
Owner Author

@Saransh-cpp Please confirm whether the UI is looking good or not. ![71](https://user-

Yes, looks awesome!

@Saransh-cpp Saransh-cpp linked a pull request Dec 30, 2021 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CodePeak moderate Moderate level issue refactor Refactor the code! SWoC ui/ux Editing the UI/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants