Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

Add new talk button keyboard functionality #75

Closed
scottaohara opened this issue Jun 4, 2018 · 3 comments · Fixed by #76
Closed

Add new talk button keyboard functionality #75

scottaohara opened this issue Jun 4, 2018 · 3 comments · Fixed by #76
Assignees

Comments

@scottaohara
Copy link
Contributor

scottaohara commented Jun 4, 2018

The "Add new talk" button now announces itself as a button and is accessible by the tab key per PR #74, but additional functionality needs to be added to this element.

Since this is a role="button" and not a true <button> element, space and enter keys do not activate the button in all browsers.

Ideally this element would be turned into a true button element and then it would work as expected. The role="button" and tabIndex="0" could then be removed. The CSS would need to be revised to allow the button element to be styled like a elements.

If changing the element is not possible, then additional JS needs to be added to allow for space and enter keys to fire the onClick function correctly.

Thanks!

@sudovijay
Copy link
Collaborator

turning the element to button seems better idea, much better than using JS on the element, making changes .. thanks ! @scottaohara never thought of this tbh !

@sudovijay sudovijay self-assigned this Jun 4, 2018
@SaraVieira
Copy link
Owner

@sudovijay sorry man, I already done this, I have too much free time :(

#76

@SaraVieira SaraVieira mentioned this issue Jun 4, 2018
@sudovijay
Copy link
Collaborator

lol @SaraVieira your fast, i actual did this too but didn't push , it just i was lookin into styled component docs to check if there's any other way to extend global styles in it without using class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants