You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 9, 2022. It is now read-only.
The "Add new talk" button now announces itself as a button and is accessible by the tab key per PR #74, but additional functionality needs to be added to this element.
Since this is a role="button" and not a true <button> element, space and enter keys do not activate the button in all browsers.
Ideally this element would be turned into a true button element and then it would work as expected. The role="button" and tabIndex="0" could then be removed. The CSS would need to be revised to allow the button element to be styled like a elements.
If changing the element is not possible, then additional JS needs to be added to allow for space and enter keys to fire the onClick function correctly.
Thanks!
The text was updated successfully, but these errors were encountered:
turning the element to button seems better idea, much better than using JS on the element, making changes .. thanks ! @scottaohara never thought of this tbh !
lol @SaraVieira your fast, i actual did this too but didn't push , it just i was lookin into styled component docs to check if there's any other way to extend global styles in it without using class.
The "Add new talk" button now announces itself as a button and is accessible by the tab key per PR #74, but additional functionality needs to be added to this element.
Since this is a
role="button"
and not a true<button>
element, space and enter keys do not activate the button in all browsers.Ideally this element would be turned into a true
button
element and then it would work as expected. Therole="button"
andtabIndex="0"
could then be removed. The CSS would need to be revised to allow thebutton
element to be styled likea
elements.If changing the element is not possible, then additional JS needs to be added to allow for space and enter keys to fire the
onClick
function correctly.Thanks!
The text was updated successfully, but these errors were encountered: