Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate itemSize into height and width #55

Open
jlnrrg opened this issue Mar 10, 2021 · 1 comment
Open

Separate itemSize into height and width #55

jlnrrg opened this issue Mar 10, 2021 · 1 comment

Comments

@jlnrrg
Copy link

jlnrrg commented Mar 10, 2021

After looking through the code I noticed that itemSized is applied to both width and height.
This is great for the use of Icons, as they are a square (at least most of the times in my understanding), but leads to issues with custom widgets.

Lets say I use a custom widget as an icon (see #54), then there is a space build, which I can not get rid off:
(notice the top and bottom space)
Screenshot from 2021-03-10 08-17-10

here it would be great imo to either have a width and height property or let the user pass a size class.

Furthermore, but this could be another issue, if no size is passed the widget should autosize based on its children.

@ariefwijaya
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants