-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toggleFullScreenMode() gives error FlutterError (Navigator operation requested with a context that does not include a Navigator #150
Comments
I have looked in to this problem. This is the most useful explanation I've found: I am utilising the I've also attempted to the This is my Material App: return new StoreProvider<AppState>(
store: widget.store,
child: MaterialApp(
title: 'Media Flutter App',
builder: (context, child) {
return StoreConnector<AppState, MediaPanelViewModel>(
converter: (store) => MediaPanelViewModel.fromStore(store),
builder: (context, viewModel) {
return Scaffold(
drawer: Drawer(),
bottomNavigationBar: viewModel.currentlyPlaying == null
? null
: MediaPanel(),
body: child,
);
});
},
initialRoute: HomeRoute,
onGenerateRoute: generateRoute,
));
Any ideas how I can fix it? I've looked through your code to see if I can find where it needs to utilise the Navigator but cant find it. |
Cloud you please provide a reproducible example ? |
yep, leave it with me |
Hi @sarbagyastha, I've created an little project to highlight the issue: To reproduce the full screen error:
Aside: This project also demonstrates a second issue, if you click on the playing video thumbnail I wanted to open it bigger at the bottom however the youtube player seems to break, I'm not sure what I'm doing wrong - maybe the webview is getting recreated. It would be nice to resolve this issue too but the full screen video issue is my main priority. Any help getting the full screen working would be massively appreciated. Thanks very much, |
Hey @sarbagyastha I think having the option of passing in a global navigator key would fix the fullscreen issue? brianegan/flutter_redux#5 (comment) What do you think? |
Hey @sarbagyastha did you manage to consider my suggestion for adding a navigator key parameter? I can implement it and send a PR if you don't have chance as this blocking me launching my app. I would just make sure that wherever you are utilising Navigator it would use the key if provided. place such as here:
|
Created a PR that fixes this issue. Could you have a look? Thanks |
Should fix with v7.0.0. Feel free to reopen if the issue persists. |
When I attempt to make the video full screen I get the following error:
I'm instegating this from a button using
The text was updated successfully, but these errors were encountered: