Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3 unusable #33

Closed
adrianvintu opened this issue Jun 23, 2019 · 5 comments
Closed

Version 3 unusable #33

adrianvintu opened this issue Jun 23, 2019 · 5 comments

Comments

@adrianvintu
Copy link

Hi there,

I was so happy to find out there is a new version.

I updated my app and everything exploded.

I tried the example on git and it is the same behavior - see this recording https://www.dropbox.com/s/ju6mu21gqocl8o5/20190623_161111.mp4?dl=0

From video:

  1. fullscreen square button does not work
  2. changing to landscape does not make the video fullscreen
  3. returning to non fullscreen mode somehow destroys the playing.

I have to revert to version 2, this new version is just not working.

I hope you can fix it soon,

Wish you good luck.

Device is Samsung Galaxy S8

@sarbagyastha
Copy link
Owner

Could you check if v3.0.0+1 fixes it ?

@adrianvintu
Copy link
Author

adrianvintu commented Jun 23, 2019

You are welcome.

  • the fullscreen button does not work - first part of video
  • first time on rotataion fullscreen does not work
  • second time on rotataion fullscreen does work
  • in fullscreen, pressing back will exit the app instead or returning to normal mode.

https://www.dropbox.com/s/lkomstrwzob3625/20190623_184825.mp4?dl=0

@sarbagyastha
Copy link
Owner

  • If device's orientation is portrait (and auto orientation is enabled) then it won't switch to fullscreen as the external button doesn't forces orientation. It's just there for demo purpose. Have you checked with the fullscreen button inside the video itself?
  • Make sure you take account the state of rotation lock too while testing.
  • Will work on implementing returning to portrait mode on back press tonight.
    Thank you for reporting an issue. Are there any other issues you've been facing in v3 ?

@Igalsr
Copy link

Igalsr commented Jun 30, 2019

Thank you for reporting an issue. Are there any other issues you've been facing in v3 ?

Hi, first of all, thank you very much for the great work.

On V3 the player doesn't work on iPhone, it tries to play and then throws an exception-

webview_flutter: unknown setting key: debuggingEnabled
flutter: player status: PlayerState.UNKNOWN

VERBOSE-2:ui_dart_state.cc(148)] Unhandled Exception: PlatformException(evaluateJavaScript_failed, Failed evaluating JavaScript, JavaScript string was: 'pause()'
Error Domain=WKErrorDomain Code=1 "An unknown error occurred" UserInfo={NSLocalizedDescription=An unknown error occurred})
#0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:564:7)
#1      MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:302:33)
<asynchronous suspension>
#2      MethodChannelWebViewPlatform.evaluateJavascript (package:ytview/src/webview_method_channel.dart:90:21)
#3      WebViewController.evaluateJavascript (package:ytview/ytview.dart:579:39)
#4      YoutubePlayerController._evaluateJS (package:youtube_player_flutter/src/youtube_player.dart:580:30)
#5      YoutubePlayerController.pause (package:youtube_player_flutter/src/youtube_player.dart:590:19)

Thanks for the help

@sarbagyastha
Copy link
Owner

sarbagyastha commented Aug 12, 2019

@Igalsr Could you check if Version 4.1.0 fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants