Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git clone error on windows #323

Closed
nicolashenry opened this issue May 13, 2020 · 6 comments · Fixed by #324
Closed

git clone error on windows #323

nicolashenry opened this issue May 13, 2020 · 6 comments · Fixed by #324

Comments

@nicolashenry
Copy link
Contributor

I wanted to clone this repository on windows to do some contribution but this error occurs:

$ git clone https://github.com/sarbbottam/eslint-find-rules.git
Cloning into 'eslint-find-rules'...
remote: Enumerating objects: 3, done.
remote: Counting objects: 100% (3/3), done.
remote: Compressing objects: 100% (3/3), done.
Receiving objects:  99% (1119/1130)d 1 (delta 0), pack-reused 1127
Receiving objects: 100% (1130/1130), 238.96 KiB | 650.00 KiB/s, done.
Resolving deltas: 100% (615/615), done.
error: invalid path 'test/fixtures/<v5/eslint-dedupe-plugin-rules.json'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

It seems that the "<" character is not supported in Windows file systems, could you rename the folder "test/fixtures/<v5" to something else?

Thanks!

@ljharb
Copy link
Collaborator

ljharb commented May 13, 2020

What happens if you clone it in git-bash or WSL?

@nicolashenry
Copy link
Contributor Author

This is the result in git bash and I can't use WSL (I am still on Windows 7).

@ljharb
Copy link
Collaborator

ljharb commented May 13, 2020

Windows 7 went EOL in January :-/

@nicolashenry
Copy link
Contributor Author

Say that to my employer :p but I am sure that it would be the same on Windows 10 with git bash anyway.

@nicolashenry
Copy link
Contributor Author

nicolashenry commented May 13, 2020

From https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file the list of reserved character on windows:
< (less than)
> (greater than)
: (colon)
" (double quote)
/ (forward slash)
\ (backslash)
| (vertical bar or pipe)
? (question mark)
* (asterisk)

@ljharb
Copy link
Collaborator

ljharb commented May 13, 2020

lol, happy to :-p

so yes, a PR that renames that dir would be fine, altho it's unfortunate any time windows' filesystem flaws imposes a cost on the wider ecocystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants