Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Delete Headers for AssignmentRecord / PersonRecord / PositionRecord #400

Open
1 of 3 tasks
alexrudall opened this issue Apr 9, 2021 · 0 comments
Open
1 of 3 tasks
Labels
bug Something isn't working in progress required for production Required before the wrapper is actively used

Comments

@alexrudall
Copy link
Collaborator

alexrudall commented Apr 9, 2021

As far as we can tell there are 3 types of records which require a start and end date to uniquely identify them, and the ID alone is not enough:

  • Assignment Record
  • PersonRecord
  • PositionRecord

Deletion rows appear as ASD, PRD, POD respectively. In practice it looks like these deletion rows only contain the ID of the records, e.g.

ASD~123456

If we receive that row, should we delete ALL AssignmentRecords containing that ID, even if there are multiple records of that type (with different dates)?

  • Find example of ASD / PRD / POD row
  • Waiting to hear back from NHS ESR team for clarification
  • Update codebase to handle them, if they include start and end dates
@alexrudall alexrudall added bug Something isn't working required for production Required before the wrapper is actively used in progress labels Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress required for production Required before the wrapper is actively used
Projects
None yet
Development

No branches or pull requests

1 participant