Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix headless not working #13

Merged
merged 3 commits into from Jan 23, 2019
Merged

Fix headless not working #13

merged 3 commits into from Jan 23, 2019

Conversation

arcps
Copy link

@arcps arcps commented Jan 23, 2019

It seen that it only works headless if setRequestInterception is true and there is and event listener on the requests 馃憪

I really don't know why, but that way is working

@sarfraznawaz2005 sarfraznawaz2005 merged commit 971d611 into sarfraznawaz2005:master Jan 23, 2019
@sarfraznawaz2005
Copy link
Owner

Thanks for the PR !

Merging for now so that others can try it. Also putting back config value window so that it's upto users to decide whether to hide window or not.

Thanks again

@kip-13
Copy link

kip-13 commented Jun 18, 2019

@arcps How did you discover this method ? Good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcps @sarfraznawaz2005 @kip-13