Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Attribute definition and XVariableDeclaration in SARL.xtext #11

Closed
srodriguez opened this issue Feb 14, 2014 · 6 comments
Closed

Comments

@srodriguez
Copy link
Member

Attribute and XVariableDeclaration have the same definition. We should have only one for both.

@srodriguez srodriguez self-assigned this Mar 20, 2014
@gallandarakhneorg
Copy link
Member

Currently is it not possible to define a static final variable.
If we merge Attribute and XVariableDeclaration, it will avoid to support this particular type of constant.

@gallandarakhneorg
Copy link
Member

Now, the inferrer is appending the keyword "static" when a val is directing initialized:

val a = 123

@gallandarakhneorg
Copy link
Member

We may merge the two grammar rules safely. It will cause a large refactoring of the inferrer, the unit tests, but not so hard.

@srodriguez
Copy link
Member Author

I am not sure that we will need new modifiers shortly, but meanwhile we'll put the issue in stand-by

@gallandarakhneorg
Copy link
Member

Ok, I have no objection for merging attribute and local name definitions.

@gallandarakhneorg
Copy link
Member

This issue is deprecated since the issue #34 will introduce the attribute definition from Xtend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants