Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the management of assertion in SARL #55

Closed
ngaud opened this issue Mar 28, 2014 · 4 comments
Closed

Add the management of assertion in SARL #55

ngaud opened this issue Mar 28, 2014 · 4 comments

Comments

@ngaud
Copy link
Member

ngaud commented Mar 28, 2014

Is it interesting to add the management of the assertions in SARL and thus the assert keyword ?

Personnally I think it is interesting. But it is not mandatory to have a keyword, since we already have an access to assertTrue from JUnit

@ngaud ngaud added the question label Mar 28, 2014
@gallandarakhneorg
Copy link
Member

But JUnit is a library that is dedicated to unit tests. It may be confusing to use a part of this API in a "standard" code.

If we decide to not introduce a keyword, I prefer to use the API given by Preconditions than the one from JUnit.

@gallandarakhneorg
Copy link
Member

One more remark: if we do not introduce a keyword, it will be difficult to detect the cases of potential null values (as done by the Java compiler).

@gallandarakhneorg
Copy link
Member

This work should be done at the same time as the one for the issue #9.

@gallandarakhneorg
Copy link
Member

This issue is related to the Xtext bug 442320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants