PP1/P2/PP3/Upload expense processes not working in dev.mod

[madhurrya]

All the errors seem to have the same issue

1. PP1 - https://dev.mod.spiff.status.im/i/36110
   

2. PP2 - https://dev.mod.spiff.status.im/i/36111
   

3. PP3 - https://dev.mod.spiff.status.im/i/36115
   

4. Upload expense - https://dev.mod.spiff.status.im/i/36116
   

[madhurrya]

@burnettk

Checked in Upload expense process and PP1 and it seems the 'currency_enum_list' is missing after the gateway

In PP2 'event_type_enum_list' is missing after the gateway

Seems to be similar to this issue #1391

[jasquat]

This was probably due to not loading task data on completed tasks. PR #1447 should address this.

[madhurrya]

@jasquat Is this already deployed to dev.mod? I am still getting those errors.

Also please push the latest models from dev.app to dev.mod.

[jasquat]

@madhurrya it was only on dev.app. pushed app and models to dev.mod.

[madhurrya]

@jasquat please add that date format change also to dev.mod.

[madhurrya]

In PP2 I am getting this error.
https://dev.mod.spiff.status.im/i/37286

And in Create event process this error
https://dev.mod.spiff.status.im/i/37291

[harmeet-status]

@calexh-sar who is this assigned to?

[jasquat]

@madhurrya I think @jakubgs needs to do that. The date configs are in place but he needs to add them to the dev.mod server.

Also, we probably shouldn't be using print inside of process models. I'm not sure what it'd print to anyway.

[burnettk]

there's a PR out to fix the "NameError:name 'events_data_store' is not defined" error.

[jasquat]

PR #1455 should address both. It fixes events_data_store directly by "fixing" the root issue and it fixes the print error by avoiding the exception block completely.

Should we add a print method? @burnettk and I were thinking it could create an event so it appears in that table. It does seem like that may be useful for debugging sometimes. Otherwise all of the print statements should be taken out of the process models since it wouldn't do anything and we do not add the method to the environment.

[madhurrya]

The 2 errors I mentioned are fixed now. Will do more testing when the date format is updated, so I can run the tests there.

[madhurrya]

Noticed this error twice so far. But it seems to be random.

https://dev.mod.spiff.status.im/i/37363
https://dev.mod.spiff.status.im/i/37384

[jasquat]

I think that issue should have been fixed by #1447. I'm not sure what task data we are missing now.

Looking at the json, it appears the 2 instances of the ending gateway - Gateway_0v1qxm0 - are marked as "COMPLETED". This would mean we probably wouldn't load the task data for one of the branches. One of the gateway instances should be "CANCELLED" so I'm not sure why that isn't happening.

[madhurrya]

Got this again. https://dev.mod.spiff.status.im/i/37407

But this is random. When I run the same test again, it'll work the next time.

[madhurrya]

Again in https://dev.mod.spiff.status.im/i/37410

https://dev.mod.spiff.status.im/i/37424

https://dev.mod.spiff.status.im/i/37432

https://dev.mod.spiff.status.im/i/37440

[madhurrya]

Is the above mentioned error is fixed or are you still working on it? Please let me know when it's fixed and deployed so I can do another round of testing in dev.mod.

[jasquat]

Deployed out to dev.mod. It should be ready to test in a bit.

[madhurrya]

Tested PP1/PP2/PP3/Upload expense evidence 3 processes/Create events and didn't notice any errors.