-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seems to still drop some markers #1
Comments
Give me the source requirements for the resolution here |
Confirmed those are all from
pytest-xdist provided those values. I think the theoretically best option is to add an extra field to the lockfile format (and |
I also still like this idea because it allows us to keep records of otherwise unresolvable dependencies together by just adding the extra marker. I still wonder if it makes sense to treat this special or to allow uniqueness in lockfiles the same way we do in the dep cache As for this specific case, I assume you looked at the various ways pipenv handles that marker? |
(This is related to not picking up |
Experiementing on requirementslib, various markers disappeared.
apipkg
, for example, got the following from PIpenv:Did it get them from
requires_python
? Because not allpython_version
markers are lost.pathlib2
, for example, keeps it fine. (Passa even gets more because it correctly merges markers!)The text was updated successfully, but these errors were encountered: