Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extras can be dropped if different dependencies require different sets #24

Closed
uranusjr opened this issue Aug 31, 2018 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@uranusjr
Copy link
Member

uranusjr commented Aug 31, 2018

Say A requires B[x], but C requires B[y], and D requires B (no extra), there is no guarantee which one will be present in the lock file. Some consolidation logic is required to merge extras.

(I found this because Passa depends on Plette[validation], but RequirementsLib depends on Plette without specifying the extra, and now the Pipfile.lock no longer contains the extra flag.)

@uranusjr uranusjr added the bug Something isn't working label Aug 31, 2018
@uranusjr
Copy link
Member Author

This will affect pin reuse as well. B[x,y] need to provide reusable pins for B, B[x], B[y], etc.

@techalchemy
Copy link
Member

This will affect pin reuse as well. B[x,y] need to provide reusable pins for B, B[x], B[y], etc.

Can you elaborate a bit on that one? or point at the code you are thinking of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants