Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for Subscript #222

Merged
merged 6 commits into from
Apr 21, 2020
Merged

Improve support for Subscript #222

merged 6 commits into from
Apr 21, 2020

Conversation

mgmarino
Copy link
Contributor

@mgmarino mgmarino commented Apr 17, 2020 •
edited
Loading

  • Fix inverted contains operands
  • Handle slices of subscripts
  • Add test case for setup files depending on environment variables

Fix #225

@mgmarino mgmarino marked this pull request as ready for review April 17, 2020 14:10
@mgmarino
Copy link
Contributor Author

This came up because I couldn't install a package using pipenv from master.

Looking forward to the release there, thanks for your work!

techalchemy
techalchemy approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@techalchemy techalchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, thanks for fixing it. I suspect this might have been tricky to debug!

@mgmarino
Copy link
Contributor Author

this is awesome, thanks for fixing it. I suspect this might have been tricky to debug!

Happy to help! It wasn't actually too bad once I had the test case.

@techalchemy techalchemy merged commit 8d7d7f5 into sarugaku:master Apr 21, 2020
@mgmarino mgmarino deleted the fix-setup-py-parsing branch April 21, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techalchemy techalchemy techalchemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In setup_info, comparator contains is called incorrectly
2 participants
@mgmarino @techalchemy