use /proc instead of ps on linux #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps is not always available in minimum linux install, like in docker containers. This change avoid to the need to install the procps package.
|
+1 for using the filesystem, was going to suggest the same. May want to handle walking |
|
Wow thanks! I thought about this as well but couldn’t find enough motivation to implement this. I will try to clean up a little and release this. |
|
Also @glehmann I sent you a collaborate invitation so I can merge things much easier :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ps is not always available in minimum linux install,
like in docker containers. This change avoid to the
need to install the procps package.