Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially support Python 3.7+ #47

Closed
JeppeKlitgaard opened this issue Apr 10, 2021 · 3 comments · Fixed by #50
Closed

Officially support Python 3.7+ #47

JeppeKlitgaard opened this issue Apr 10, 2021 · 3 comments · Fixed by #50

Comments

@JeppeKlitgaard
Copy link
Contributor

Currently Python 3.6 is the most recent supported version according to the classifiers specified in setup.cfg.

Python 3.6 is due to lose support later this year and most will probably have migrated to Python 3.8 or 3.9 at this point.

As far as I can tell shellingham works perfectly fine on these more recent Python versions - it might be worthwhile to make the classifiers reflect this and perhaps set up a Python version test matrix on CI?

@uranusjr
Copy link
Member

Absolutely! A pull request would be very welcomed.

@JeppeKlitgaard
Copy link
Contributor Author

I'll gladly put something together, though I am not entirely sure how to implement the test matrix on Github Actions.

Thanks for getting back to me so quickly!

@JeppeKlitgaard
Copy link
Contributor Author

@uranusjr would you consider removing support for old Python versions, or would you prefer to keep support for Python 2?

The following versions have reached end of life:

  • Python 2.6
  • Python 2.7
  • Python 3.4
  • Python 3.5

(see also: https://endoflife.date/python)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants