Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two methods for checkitems #334

Merged
merged 9 commits into from May 12, 2021

Conversation

rdorrigan
Copy link
Contributor

The methods below set due dates and add members. The Trello API does not list either actions officially but does support it it in the UI and both worked in my production environment.
set_checklist_item_due()
set_checklist_item_member()

Methods set due dates and add members
Add a start date and set a reminder for the due date with:
set_start
set_reminder
@xu2xulim
Copy link

Line 551 remainder = int(remainder) does not allow for string like “60.5”. Suggest remainder = int(float(remainder))

reminder = int(float(reminder)) to account for floats passed as strings
@rdorrigan
Copy link
Contributor Author

Thank you! Updated.

@xu2xulim
Copy link

xu2xulim commented Mar 1, 2021

Based on my test, it seems that member and due dates will not be visible unless you are on business class. Do you have the same experience?

@rdorrigan
Copy link
Contributor Author

I'm on a business class account for work, and am not experiencing that issue. I could note this in the comments.

update_custom_field_definition
update_custom_field_definition
Almost forgot to add them here
@xu2xulim
Copy link

xu2xulim commented Mar 2, 2021

Add file via Upload👏🤞👍✅

trello/board.py", line 222
    arguments["display/cardFront"] = u"true" if display_on_card else u"false"
                                                                            ^
TabError: inconsistent use of tabs and spaces in indentation
get_custom_field_list_options
add_custom_field_list_option
get_custom_field_list_option
delete_custom_field_list_option
@sarumont
Copy link
Owner

Happy to merge if you can resolve the conflicts!

@rdorrigan
Copy link
Contributor Author

Conflicts resolved. I know I had an odd response with a 'checkbox' custom_field.field type. Which required the conflicting edits. I'll see if I can find some evidence and make another pull request later on.

@rdorrigan rdorrigan closed this May 11, 2021
@rdorrigan rdorrigan deleted the dev-needs-testing branch May 11, 2021 22:44
@rdorrigan rdorrigan restored the dev-needs-testing branch May 11, 2021 22:50
@rdorrigan
Copy link
Contributor Author

Reopening, I accidentally closed by trying to tidy up branch names.

@rdorrigan rdorrigan reopened this May 11, 2021
@sarumont
Copy link
Owner

Thanks, @rdorrigan! Merged!

@sarumont sarumont merged commit cfb081d into sarumont:master May 12, 2021
@xu2xulim
Copy link

xu2xulim commented Jul 3, 2021

@rdorrigan
Got this when testing the delete_custom_field_option.

trello.exceptions.ResourceUnavailable: {"error":"CUSTOM_FIELD_OPTION_NOT_FOUND","message":"Custom field option not found"} at https://api.trello.com/1/customFields/60d998eff903b078cdc2fc3c/options/60d998eff903b078cdc2fc3c (HTTP status: 404)

Both the definition ID and the option ID are the same? When I define my own def with

json_obj = client.fetch_json(
        'customFields/{0}/options/**{1}**'.format(custom_field_definition_id,option_id),
        http_method='DELETE',

for it to work. See highlighted portion {1}.
The same issue with get_custom_field_list_option

@rdorrigan
Copy link
Contributor Author

@xu2xulim Thank you for identifying the error. I've tested and committed the requested changes. @sarumont would prefer a new pull request be opened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants