Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite /api/generate_slang route to use internal (new) functionality. #29

Closed
Sasafrass opened this issue Jul 17, 2021 · 0 comments · Fixed by #52
Closed

Rewrite /api/generate_slang route to use internal (new) functionality. #29

Sasafrass opened this issue Jul 17, 2021 · 0 comments · Fixed by #52
Assignees
@annaproxy @Sasafrass
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
Main

Comments

@Sasafrass
Copy link
Owner

Rewrite /api/generate_slang route to use the internal functionality rather than defining functionality itself. In this way, any update to how we generate words in the internal functionality should immediately take effect here as well, dispensing with the need to update this manually == fewer bugs.
@Sasafrass Sasafrass added enhancement New feature or request invalid This doesn't seem right labels Jul 17, 2021
@Sasafrass Sasafrass added this to To do in Main Jul 17, 2021
@Sasafrass Sasafrass moved this from To do to In progress in Main Jul 19, 2021
@Sasafrass Sasafrass linked a pull request Jul 19, 2021 that will close this issue
Implement internal call so we can load model from session. #52
Merged
@Sasafrass Sasafrass moved this from In progress to Done in Main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annaproxy annaproxy

@Sasafrass Sasafrass

Labels
enhancement New feature or request invalid This doesn't seem right
Projects
Main
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement internal call so we can load model from session. Sasafrass/straattaal
2 participants
@annaproxy @Sasafrass