Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardcoded number of letters. #4

Closed
Sasafrass opened this issue Jul 11, 2021 · 1 comment
Closed

Fix hardcoded number of letters. #4

Sasafrass opened this issue Jul 11, 2021 · 1 comment
Assignees
@raoulg
Labels
enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right

Comments

@Sasafrass
Copy link
Owner

The number of letters used for the loaded model is currently hardcoded. Find a better way to change this depending on the corpus we're dealing with. First solution would be to have this at least be variable for the Slang corpus.

File and line:

straattaal/app/ml_models/rnn/loaded_rnn_model.py

Line 10 in 0493287

n_letters = 27 # TODO: Fix the hardcoded number of letters.

@Sasafrass Sasafrass added enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right labels Jul 11, 2021
@Sasafrass
Copy link
Owner Author

Has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raoulg raoulg

Labels
enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raoulg @Sasafrass