Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance value is set too late. #5

Closed
mrcrowl opened this issue Oct 10, 2018 · 4 comments
Closed

Instance value is set too late. #5

mrcrowl opened this issue Oct 10, 2018 · 4 comments

Comments

@mrcrowl
Copy link

mrcrowl commented Oct 10, 2018

A recent commit 810b719 modified metadata.ts so that this line:
Vue.set(instance, propertyName, instance[propertyName]);
Now appears after the property is replaced with a getter/setter.

This causes all initial values in the store to be undefined.

See:

Vue.set(instance, propertyName, instance[propertyName]);

@sascha245
Copy link
Owner

Oh, my bad! Will fix it as soon as possible.
Strange that my tests passed fine, looks like I will have to review those too.

@mrcrowl
Copy link
Author

mrcrowl commented Oct 10, 2018

Good work, btw. I like the track that you're on with this package.

@sascha245
Copy link
Owner

Thanks ^^ Though there are still quite a lot of improvements to be done here and there.

@sascha245
Copy link
Owner

Normally this issue should now be fixed in commit d560982 or 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants