Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad NodeId.index? #14

Closed
ArnaudValensi opened this issue Jul 31, 2018 · 3 comments
Closed

Bad NodeId.index? #14

ArnaudValensi opened this issue Jul 31, 2018 · 3 comments

Comments

@ArnaudValensi
Copy link

You are using ˋself.nodes.len()` to get the next index, but if you add 2 nodes, then remove the first one, then add a node, both nodes will have the same index right ?

@saschagrunert
Copy link
Owner

How would you remove a node? :)

@ArnaudValensi
Copy link
Author

Ok, if my understanding is correct, this data structure is not meant to move or remove nodes. It does not fit my usecase, but your code is inspiring for my needs. Thanks.

@saschagrunert
Copy link
Owner

Yes, it would be possible to add this feature but implies a bit more garbage collection. Maybe in the future. :) thank you for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants