Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sasjs folder move #174

Closed
4 of 5 tasks
allanbowe opened this issue Oct 17, 2020 · 2 comments · Fixed by #383
Closed
4 of 5 tasks

sasjs folder move #174

allanbowe opened this issue Oct 17, 2020 · 2 comments · Fixed by #383
Assignees
Labels
bug Something isn't working released

Comments

@allanbowe
Copy link
Member

allanbowe commented Oct 17, 2020

There is a bug in sasjs folder move

image

The result was:

image

In any case, the behaviour may need to be revisited. It would be more useful / intuitive if the move command could move AND rename a folder, in which case it would be more like the linux mv. The behaviour would depend on the presence of a trailing /. If a trailing / is provided, the folder is moved to the specified parent. If none provided, then the folder is moved and renamed.

sasjs folder move <sourcefolder> <targetfolder>

To enable automated testing, we should also create a sasjs folder list command, which will list all the immediate children of a folder (and their types).

Definition of done:

  • sasjs folder move /Public/example1 /Public/example2 will rename example1 to example2 (unless example2 exists, in which case it will fail)
  • sasjs folder move /Public/nested/folder /Public/ will move folder to /Public/folder
  • the presence of a leading / determines whether to prepend the path with the value of appLoc
  • sasjs folder list command created & documented
  • we have automated tests to confirm the above behaviours
@allanbowe allanbowe added the bug Something isn't working label Oct 17, 2020
@medjedovicm medjedovicm self-assigned this Nov 18, 2020
@medjedovicm
Copy link
Member

sasjs/adapter#186

@medjedovicm medjedovicm mentioned this issue Jan 5, 2021
6 tasks
@ghost
Copy link

ghost commented Feb 25, 2021

🎉 This issue has been resolved in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants