fix(web): list all not found assets #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
krishna-acondy
previously approved these changes
Sep 18, 2021
|
@saadjutt01 You might want to change the PR title to something more descriptive, starting with |
Updated. |
krishna-acondy
approved these changes
Sep 20, 2021
|
Server tests failed |
|
🎉 This PR is included in version 2.38.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #997
Closes #757
Intent
Print helpful message in case of missing assets while
sasjs webPrint message for UNC paths not supported while
sasjs docImplementation
Throwing error message for UNC paths.
Catching all the missing assets and printing on on console.
Rest of the changes are the removal of unnecessary usage of
await.Checks
npm run lint:fix).npm test).Mocked:
Server: