Escape non-US-ASCII characters in SassException.toCssString()
#2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Dec 8, 2023
lmeysel
pushed a commit
to lmeysel/dart-sass
that referenced
this pull request
Feb 20, 2024
…#2143) Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
SassException.toCssString()would write code points between 128 and 255 in UTF-8. The result cannot be parsed as US-ASCII (ASCII-7BIT).UTF-8 encoded file with only code points less than 128 is completely interchangeable with US-ASCII. Therefore, this PR further escapes code points between 128 and 255.