Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why are source_comments forced to True when generating maps? #124

Closed
tisdall opened this issue Mar 4, 2016 · 7 comments
Closed

why are source_comments forced to True when generating maps? #124

tisdall opened this issue Mar 4, 2016 · 7 comments

Comments

@tisdall
Copy link
Contributor

tisdall commented Mar 4, 2016

This is related to #94 as it's also about comments appearing in the compiled css. I find it strange that when you request a sourcemap that the code forces comments on. Is that necessary?

The lines in question: https://github.com/dahlia/libsass-python/blob/python/sass.py#?L540-L541

The lines were added in fea52df but I can't really figure out why. @dahlia, is it okay to remove that?

@asottile
Copy link
Member

asottile commented Mar 4, 2016

This is one thing I've been meaning to fix up since we'd like to use this feature as well. I'm planning to see what the node / perl implementations do for source maps and emulate that here

@tisdall
Copy link
Contributor Author

tisdall commented Mar 4, 2016

In the perl implementation it seems it just has "source_comment" as a command line argument and uses whatever is passed in. It seems to be completely independent of maps.

@tisdall
Copy link
Contributor Author

tisdall commented Mar 4, 2016

^_^ I tried just commenting out the two lines I mentioned and it seems the .map file is now empty... So, I guess I found the reason for the code.

@tisdall
Copy link
Contributor Author

tisdall commented Mar 4, 2016

@tisdall
Copy link
Contributor Author

tisdall commented Mar 4, 2016

I guess as a "TODO" it'd be nice to add a command line argument that set whether or not debugging comments are added.

@asottile
Copy link
Member

asottile commented Mar 8, 2016

Via #130

@asottile asottile closed this as completed Mar 8, 2016
@asottile
Copy link
Member

This is part of 0.11.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants