Add option to strip extensions for wsgi / distutils integration #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a start of a fix for #55 @dahlia -- this is the careful approach, we could also just change the default to CC @maki-markie |
dahlia
reviewed
Aug 15, 2018
sassutils/builder.py
Outdated
| sass_path, | ||
| css_path=None, | ||
| wsgi_path=None, | ||
| strip_extension=False, |
There was a problem hiding this comment.
How about defaulting this to None at this point? We could warn as well if it's None (implying a user doesn't pass True nor False explicitly) for some period, and finally change the default value to False at some point.
There was a problem hiding this comment.
you mean True eventually right :)
This was referenced Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.