Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hue() function returns negative values. #1132

Closed
isGabe opened this issue Apr 24, 2015 · 3 comments · Fixed by #1134
Closed

hue() function returns negative values. #1132

isGabe opened this issue Apr 24, 2015 · 3 comments · Fixed by #1134
Assignees
@xzyfer
Labels
Bug - Confirmed Dev - Test Written
Milestone
3.2

Comments

@isGabe
Copy link

isGabe commented Apr 24, 2015

I just came across this issue, where LibSass will sometimes return a negative value for the hue() function, which doesn't seem right.

Simple example that I just ran on sassmeister.com
hue(#ab0520) will return:

-9.75904deg; in LibSass (v3.1.0),
350.24096deg; in Ruby Sass (v3.4.12)
@xzyfer xzyfer added this to the 3.2 milestone Apr 25, 2015
@xzyfer xzyfer removed this from the 3.2 milestone Apr 25, 2015
@xzyfer xzyfer added this to the 3.2.1 milestone Apr 25, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Apr 25, 2015

Thanks for the report @fStop. I've confirmed this is an issue.

Please create a sass-spec test case for this. This is a good example to follow sass/sass-spec#343

@xzyfer xzyfer mentioned this issue Apr 25, 2015
Merged
@xzyfer
Copy link
Contributor

xzyfer commented Apr 25, 2015

Specs added sass/sass-spec#347

This was referenced Apr 25, 2015
Merged
Merged
@xzyfer xzyfer modified the milestones: 3.2.1, 3.2 Apr 25, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Apr 25, 2015

Ended up squeezing this into 3.2 because I knew what was wrong and hoped it would also fix #1101 (which it did not)

@xzyfer xzyfer self-assigned this Apr 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzyfer xzyfer

Labels
Bug - Confirmed Dev - Test Written
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Fix the RGB to HSL algorithm xzyfer/libsass
2 participants
@xzyfer @isGabe