Improved Makefile #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove "-c" from CFLAGS and hard-code it into the recipe -- CFLAGS should be overridable from the command-line but not including "-c" should never invoke the linker on object files * Use real target names for library files instead of phony targets * Add install and install-shared targets * Use $(OBJECTS) instead of *.o * Use .PHONY to properly mark phony targets
|
Thanks for the help! Makefiles are not exactly our forte. I'll merge this in when I'm at my dev machine. |
thatguystone
pushed a commit
to thatguystone/libsass
that referenced
this pull request
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, sorry for the mail spam. This is a rebased version of my last 2 (closed) pull requests.
-cfromCFLAGSand hard-code it into the recipe -- failing to include-cwhen overriding CFLAGS via the command-line shouldn't invoke the linker on object filesinstallandinstall-sharedtargets (closes Improve Makefile #14)$(OBJECTS)instead of*.o.PHONYto properly mark phony targets